[
https://issues.apache.org/jira/browse/CB-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695997#comment-15695997
]
ASF GitHub Bot commented on CB-12154:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/170
CB-12154 file-transfer progressEvent.total = -1 on iOS
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Reverts logic for not setting `Content-Length` for `chunkedMode=true`.
This was causing progress events total to be -1 and progress to be not
computable.
So while this change technically violates the
[specification](https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4)
it fixes the functionality.
### What testing has been done on this change?
Manual and autotests.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-file-transfer CB-12154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit c8b387ccab8b09027a6fc13888b73103054f4b25
Author: daserge <[email protected]>
Date: 2016-11-23T15:57:11Z
CB-12154 file-transfer progressEvent.total = -1 on iOS
Makes chunkedMode=true uploads to contain Content-Length to make progress
computable
----
> file-transfer progressEvent.total = -1 on iOS
> ---------------------------------------------
>
> Key: CB-12154
> URL: https://issues.apache.org/jira/browse/CB-12154
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Reporter: samed ceylan
> Priority: Critical
> Labels: ios, reproduced, triaged
>
> cordova-plugin-file-transfer bug progressEvent.total = -1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
