[
https://issues.apache.org/jira/browse/CB-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701387#comment-15701387
]
ASF GitHub Bot commented on CB-9287:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89726640
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -541,4 +541,165 @@ describe('copyIcons method', function () {
expect(FileUpdater.updatePaths).toHaveBeenCalledWith(expectedPathMap, {
rootDir: PROJECT }, logFileOp);
});
});
+
+ it('should ignore splashScreens for Windows 10 project with size >200K
and emit a warning', function () {
+ var size300K = 300 * 1024;
+ var warnSpy = jasmine.createSpy('warn');
+ events.on('warn', warnSpy);
+
+ var splashScreensFiles = [
--- End diff --
Nit: this could be calculated from `splashScreens`:
`splashScreens.map(splash => path.basename(splash.src)`
> Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
> ------------------------------------------------------------------------
>
> Key: CB-9287
> URL: https://issues.apache.org/jira/browse/CB-9287
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin SplashScreen, Windows
> Affects Versions: 4.0.0
> Environment: Cordova 4.0.0, Windows Platform 3.7.1
> Reporter: Dennis Patzer
> Assignee: Jesse MacFadyen
> Labels: triaged, windows
> Attachments: splashscreens_windows_universal_app.jpg
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> For some reason, for example only one splashscreen size is supported
> (620x300). When I add other sizes by adding the following line:
> <splash
> src="../resources/themes/windows-phone/img/splashscreen/splashscreen.scale-140.png"
> width="868" height="420" />
> The image isn't copied to the cordova/platforms/windows/images folder when
> building. This is the reason why it's also not included and referenced in the
> resulting package.windows.appxmanifest.
> Why is that?? Or am I doing something wrong?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
