[
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704775#comment-15704775
]
ASF GitHub Bot commented on CB-10228:
-------------------------------------
GitHub user kelvinhokk opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
CB-10228:(iOS) AppendUserAgent not working with WKWebView
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS: Currently the wkWebview users the default user agent, ignoring
Cordova's OverrideUserAgent and AppendUserAgent in config.xml
### What does this PR do?
This attempts to set the customUserAgent property of the wkWebview to what
is already computed in the CDVViewController
### What testing has been done on this change?
Npm tests have been run. User agents verified changed on Cordova iOS 4.3.0
and Cordova 6.4.0.
### Checklist
- [ X] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelvinhokk/cordova-plugin-wkwebview-engine
master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 8014757681d79fc83d96bff00ca1b262f0b4b25b
Author: kelvinho <[email protected]>
Date: 2016-11-29T09:20:02Z
CB-10228:(iOS) AppendUserAgent not working with WKWebView
----
> AppendUserAgent not working with WKWebView
> ------------------------------------------
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Reporter: vB Results, LLC.
> Assignee: Shazron Abdullah
> Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4
> and AppendUserAgent is the most lightweight way to detect whether or not we
> are in the app on a remote site. Please fix, the lack of this means we
> cannot benefit from using WKWebView :(
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
