[ 
https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712808#comment-15712808
 ] 

ASF GitHub Bot commented on CB-11714:
-------------------------------------

GitHub user DisruptiveMind opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/242

    CB-11714: (windows) added check for encoding in savePhoto() without 
height/width

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows 10
    
    ### What does this PR do?
    Adds extra content-type check when capturing photos without specifying 
targetWidth and/or targetHeight in options to preserve JPEG file extension.
    
    ### What testing has been done on this change?
    ditto
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DisruptiveMind/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
    
----

----


> Camera plugin for windows does not properly set content-type when selecting 
> JPG->PNG
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11714
>                 URL: https://issues.apache.org/jira/browse/CB-11714
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>              Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the 
> resizeImage() will not modify the target content type when converting 
> canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a 
> .png extension which will cause the browser to not render to image and issue 
> an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to