[ 
https://issues.apache.org/jira/browse/CB-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713364#comment-15713364
 ] 

ASF GitHub Bot commented on CB-8260:
------------------------------------

GitHub user VinceOPS opened a pull request:

    https://github.com/apache/cordova-browser/pull/25

    CB-8260: (browser) Fix corrupted zip file (build)

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Platform "browser" only.
    
    ### What does this PR do?
    Replace the node module `adm-zip`, which is known for corrupting some files 
when compressing a folder to a zip archive, by the module `archiver`.
    Update the build script in order to use `archiver` instead of `adm-zip`.
    
    ### What testing has been done on this change?
    Making sure that all the different types of file bundled in the newly built 
package.zip were properly compressed, and uncompressed.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/VinceOPS/cordova-browser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 4ea3ad76414727e732e80ce69e100522e5dddc92
Author: Vince <vince.g....@gmail.com>
Date:   2016-12-01T22:50:23Z

    CB-8260: (browser) Fix corrupted zip file (build)

----


> Error when unzipping build zip package
> --------------------------------------
>
>                 Key: CB-8260
>                 URL: https://issues.apache.org/jira/browse/CB-8260
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Browser
>            Reporter: Sam Verschueren
>
> When I build my project with 'cordova build browser', a zip file will be 
> created under the build folder. When I unzip that folder I get the following 
> errors for certain files:
> error:  invalid compressed data to inflate
> It seems that the problem lays in the adm-zip module used to create that zip 
> package. Other people have reported the same issue in the issue tracker of 
> adm-zip (https://github.com/cthackers/adm-zip/issues/102).
> This could be solved by using another archiver module like 
> https://github.com/ctalkington/node-archiver as suggested by another user in 
> the issue tracker of adm-zip.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to