[
https://issues.apache.org/jira/browse/CB-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726727#comment-15726727
]
ASF GitHub Bot commented on CB-12163:
-------------------------------------
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-windows/pull/213
CB-12163 Make resource-file copy files again
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- Windows
### What does this PR do?
- Revert the functionality of resource-file in plugin.xml. It will now copy
files again instead of using the references.
### What testing has been done on this change?
- Updated the spec tests and ran them
- Created a new app with the updated resource-file and check to see if it
copies files.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktop/cordova-windows cb12163
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit d00e0c33d388f410d6444920d72b7ac1e86df3ef
Author: ktop <[email protected]>
Date: 2016-12-06T20:58:42Z
CB-12163 Make resource-file copy files again
----
> plugin.xml 'resource-file' does not copy file to target for Windows
> -------------------------------------------------------------------
>
> Key: CB-12163
> URL: https://issues.apache.org/jira/browse/CB-12163
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: Master
> Environment: Windows 8/Windows10
> Reporter: Karen Tran
> Labels: Windows
>
> From plugin.xml:
> {noformat}<resource-file src="windows/shared/myprops.properties"
> target="myprops.properties"/>{noformat}
> <resource-file> does not copy the file from src to target anymore. It used
> to, but was changed. This creates a couple of issues since I expect it to be
> in the application, but it technically isn't. This means that I cannot update
> the file that doesn't exist and very much limits the functionality of
> <resource-file> (Also the documentation is wrong for Windows since it doesn't
> copy any files). Visual Studio also only shows the file from the src path.
> This doesn't make much sense since that file wouldn't be in the application.
> The expected behavior should be if the target is specified, <resource-file>
> should copy the file to the target location. In turn, Visual Studio should
> show the target file instead of the src file because the target is part of
> the application whereas the src file is not.
> This used to be expected behavior, but was changed as a result of CB-10326.
> The intention of that issue is limited to use cases of only having the src
> attribute, ignoring the possibility that we would want to update files in the
> target instead (which imo makes more sense). Resource files are not all .dll
> files, so it's not very user friendly to limit the <resource-file> tag to
> handling just those kinds of files.
> Proposed changes in JsprojManager.js and PluginHandler.js:
> If target attribute is specified, copy the file to the target and point the
> Include attribute to the path of the target.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
