[
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745743#comment-15745743
]
ASF GitHub Bot commented on CB-11908:
-------------------------------------
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/508
CB-11908 Add tests for edit-config in config.xml and fix typo
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
cordova-common
### What does this PR do?
I had this commit ready to go, but forgot to commit and push it. Here I'm
adding tests for the 'edit-config' functionality that was added to config.xml.
### What testing has been done on this change?
Manual tests and adding unit tests.
### Checklist
- [x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktop/cordova-lib editconfigxml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #508
----
commit aa4c6e8380c6e5edf1bf20a508b450e64a1d6e7c
Author: ktop <[email protected]>
Date: 2016-12-09T19:53:50Z
CB-11908 Add tests for edit-config in config.xml and fix typo
Add one more test case
----
> Add edit-config to config.xml
> -----------------------------
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaCommon, CordovaLib
> Affects Versions: Master
> Reporter: Karen Tran
> Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from
> plugins.
> This feature should be added to config.xml as well, so that users wouldn't
> need a plugin in order to modify xml elements.
> *config.xml changes takes precedence over plugin changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
