[
https://issues.apache.org/jira/browse/CB-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751297#comment-15751297
]
ASF GitHub Bot commented on CB-11177:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
extendedSplashProgress.classList.add('win-medium');
extendedSplashProgress.classList.add('win-ring');
+ extendedSplashImage.style.maxWidth = "100%";
+ extendedSplashImage.style.maxHeight = "100%";
+ extendedSplashImage.src = splashImageSrc;
+
if (isWp81 || isWp10) {
- extendedSplashImage.style.maxWidth = "100%";
- extendedSplashImage.style.maxHeight = "100%";
- extendedSplashImage.src = splashImageSrc;
// center horizontally
extendedSplashImage.style.margin = "0 auto";
- extendedSplashImage.style.display = "block";
+ extendedSplashImage.style.display = "inline-block";
--- End diff --
Can we move this to CSS using the same technique as for
`extendedSplashProgress` (additional css classes based on whether we're running
on desktop/phone)?
> SplashScreen gets shifted on Windows devices with soft navbar
> -------------------------------------------------------------
>
> Key: CB-11177
> URL: https://issues.apache.org/jira/browse/CB-11177
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Labels: mustfix, splashscreen, triaged
> Attachments: extendedSplash[1].png, launchImage[1].png
>
>
> This can be partially avoided by showing a statusbar:
> {noformat}
> var statusBar = Windows.UI.ViewManagement.StatusBar.getForCurrentView();
> if (statusBar) {
> statusBar.backgroundColor = { a: 0, r: 41, g: 40, b: 38 };
> statusBar.backgroundOpacity = 1;
> statusBar.showAsync();
> }
> {noformat}
> This should be conditional to soft navigation bar presence though.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
