[
https://issues.apache.org/jira/browse/CB-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761042#comment-15761042
]
ASF GitHub Bot commented on CB-12271:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/6
CB-12271 (windows) Fixed "platform add" error, added new tests
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Fixes an error on plugin add to windows project. Also, adds a couple of
tests to test sanity of `screen.lockOrientation()` and
`screen.unlockOrientation()` methods.
https://issues.apache.org/jira/browse/CB-12271
### What testing has been done on this change?
Automated paramedic testing on Windows and Android.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation
CB-12271
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit af87296d219198071982fd33537dc44a1fdbcbe5
Author: Alexander Sorokin <[email protected]>
Date: 2016-12-19T12:13:57Z
CB-12271 (windows) Fixed "platform add" error, added new tests
----
> cordova-plugin-screen-orientation cannot be added to windows project
> --------------------------------------------------------------------
>
> Key: CB-12271
> URL: https://issues.apache.org/jira/browse/CB-12271
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Screen Orientation
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> {noformat}
> Error: Uh oh!
> ENOENT: no such file or directory, open
> 'C:\Users\jenkins\AppData\Local\Temp\tmp-11192lBRTyUnN5lcS\plugins\cordova-plugin-screen-orientation\src\windows\CDVOrientationProxy.js'
> {noformat}
> Full log:
> http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/1/PLATFORM=windows-10-store/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
