[
https://issues.apache.org/jira/browse/CB-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766888#comment-15766888
]
ASF GitHub Bot commented on CB-12189:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/513
CB-12189 windows: Add `implementation` attribute to frameworks
The attribute is windows-specific and allows to specify implementation for
WinMD components, written in C++
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12189
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 5be6a8166fd9785dec095c99836cba725fb4947e
Author: Vladimir Kotikov <[email protected]>
Date: 2016-12-21T12:00:57Z
CB-12189 Add implementation attribute to framework
The attribute is windows-specific and allows to specify implementation for
WinMD components, written in C++
----
> Plugin WinMD+DLL combination
> ----------------------------
>
> Key: CB-12189
> URL: https://issues.apache.org/jira/browse/CB-12189
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Chris Brody
>
> As discussed in https://forums.adobe.com/message/9123283 and
> https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10
> it is not possible to build on PhoneGap Build for Windows with a plugin such
> as https://github.com/litehelpers/Cordova-sqlite-legacy-build-support or
> https://github.com/litehelpers/Cordova-sqlite-evcore-extbuild-free. The
> solution discussed in
> https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10
> is to build the Windows C++ library by hand then include the WinMD file in
> plugin.xml just like
> https://github.com/phonegap/phonegap-plugin-barcodescanner/blob/master/plugin.xml#L65-L67.
> But as discussed in
> https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10
> this is still not possible since we need to include both WinMD and DLL files
> in case of a C++ library.
> I hereby raise this issue to fix cordova-windows to support WinMD+DLL for C++
> libraries such as
> https://github.com/litehelpers/Cordova-sqlite-legacy-build-support. This is a
> blocking issue for one of my customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
