[ 
https://issues.apache.org/jira/browse/CB-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795290#comment-15795290
 ] 

ASF subversion and git services commented on CB-12312:
------------------------------------------------------

Commit 05594c46468576da846b31b03e624d72f7c9c476 in cordova-plugin-camera's 
branch refs/heads/master from filmaj
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=05594c4 
]

CB-12312: [Appium] [Android] A few changes to the tests:
 - updated comments on how to run the tests. extra comments around 
functionality at certain points in the automation.
 - stub of a resolution checker on test startup - still need to figure out 
acceptable values.
 - moved session shutdown to an afterAll clause.
 - changed resolution determiner from using webview-based values to using the 
native windows dimensions - this helps as the webview values may be scaled down 
intentionally by manufacturers (via changing devicePixelRatio). furthermore, 
since the screen dimension automation is used purely for native UI automation, 
better to use the dimensions reported by the native context rather than the web 
context.
 - when finding elements by XPath, use multiple calls to avoid a Windows 
emulator + Android bug. Made this pattern consistent in the entire test.


> Camera plugin Android ui tests checkup
> --------------------------------------
>
>                 Key: CB-12312
>                 URL: https://issues.apache.org/jira/browse/CB-12312
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>            Priority: Minor
>
> A few improvements should be added to the Android-specific Appium camera 
> plugin tests:
>  - working instructions on how to run them
>  - resolution retrieval should be done from the native side, not the webview 
> side
>  - consistent use of double-element-finding on Android
>  - use of before/after clauses via jasmine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to