[ 
https://issues.apache.org/jira/browse/CB-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796556#comment-15796556
 ] 

Jess Holle commented on CB-12283:
---------------------------------

Either Cordova supports multipart PluginResults or it doesn't.

If it does, then there should either be an existing test case or one should be 
created to validate this functionality for all current/future supported bridge 
modes.

If not, then this should be clearly documented and an alternative provided in 
the documentation.

I don't have a standalone test case handy.  If a fix is provided I could, 
however, patch it into our build and see if it resolves the issue.

The lack of code to handle this use case is readily apparent without any test 
case.

> EVAL_BRIDGE does not support multipart PluginResults
> ----------------------------------------------------
>
>                 Key: CB-12283
>                 URL: https://issues.apache.org/jira/browse/CB-12283
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0
>            Reporter: Jess Holle
>            Assignee: Joe Bowser
>              Labels: regression
>
> When moving from Cordova 5.1.1 to 6.0.0 our multi-part PluginResult 
> communication started failing (without any other changes to the application). 
>  This issue goes away if we force use of ONLINE_EVENT rather than EVAL_BRDIGE 
> mode.
> Further investigation shows that with EVAL_BRIDGE multi-part PluginResults 
> result in [""] being sent as the response data, e.g.:
> cordova.callbackFromNative('Vuforia296582484',true,1,[""],true);
> This is clearly wrong and a result of 
> JsMessage.encodeAsJsMessage(StringBuilder) having no case for 
> MESSAGE_TYPE_MULTIPART (nor any appropriate delegate to ensure proper 
> handling).  Reviewing the 6.1.0 sources suggests this has still not been 
> fixed there.
> Given the switch of the default bridge mode on Android to EVAL_BRIDGE, this 
> is a very serious regression and breakage of existing plugins.  This should 
> either be fixed or the bridge mode reverted to ONLINE_EVENT once again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to