[
https://issues.apache.org/jira/browse/CB-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799214#comment-15799214
]
ASF GitHub Bot commented on CB-12098:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/285
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr) is 64.11%
(diff: 100%)
> Merging [#285](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr)
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr)
will not change coverage
```diff
@@ master #285 diff @@
==========================================
Files 12 12
Lines 1360 1360
Methods 208 208
Messages 0 0
Branches 229 229
==========================================
Hits 872 872
Misses 488 488
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[5463937...902c7f8](https://codecov.io/gh/apache/cordova-ios/compare/5463937695f783e72f32d4953e13bfe4d79855ab...902c7f8cc662cce31c37a11e85071ec8843c0d49?src=pr)
> Update supportedInterfaceOrientations return type
> -------------------------------------------------
>
> Key: CB-12098
> URL: https://issues.apache.org/jira/browse/CB-12098
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 3.5.0
> Reporter: Jesse MacFadyen
> Assignee: sterling gerritz
> Priority: Minor
>
> All of our uses of supportedInterfaceOrientations should return
> UIInterfaceOrientationMask in iOS 9+
> {code}
> #if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
> - (NSUInteger)supportedInterfaceOrientations
> #else
> - (UIInterfaceOrientationMask)supportedInterfaceOrientations
> #endif
> {code}
> The full list of references is here:
> https://github.com/apache/cordova-ios/search?utf8=%E2%9C%93&q=supportedInterfaceOrientations
> A similar fix was just implemented for [CB-11189]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
