[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802917#comment-15802917
 ] 

ASF GitHub Bot commented on CB-12261:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/511


> subdirectories deprecated warning always shows and stop fetch
> -------------------------------------------------------------
>
>                 Key: CB-12261
>                 URL: https://issues.apache.org/jira/browse/CB-12261
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>         Environment: Any
>            Reporter: Wilson Yang
>            Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to