[
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815255#comment-15815255
]
ASF GitHub Bot commented on CB-11154:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/54
CB-11154 (Windows) Return IANA timezone as an empty string instead of…
… undefined
### Platforms affected
Windows
### What does this PR do?
Adds an empty IANA Timezone value to DatePattern object on Windows platform.
https://issues.apache.org/jira/browse/CB-11154
### What testing has been done on this change?
Paramedic testing on Windows 10 and Android 4.4
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-globalization
CB-11154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-globalization/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 24a7eb4faa363a82d5f73c8441dd266921d44627
Author: Alexander Sorokin <[email protected]>
Date: 2017-01-10T15:16:52Z
CB-11154 (Windows) Return IANA timezone as an empty string instead of
undefined
----
> Why timezone is not IANA ?
> --------------------------
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Globalization
> Reporter: Simon Constans
> Labels: triaged
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository:
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android:
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone:
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
