[ 
https://issues.apache.org/jira/browse/CB-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816719#comment-15816719
 ] 

ASF GitHub Bot commented on CB-12018:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/265#discussion_r95493138
  
    --- Diff: spec/cli.spec.js ---
    @@ -134,11 +134,11 @@ describe("cordova cli", function () {
     
         describe("create", function () {
             beforeEach(function () {
    -            spyOn(cordova.raw, "create").andReturn(Q());
    -            spyOn(cordova_lib, "CordovaError");
    +            spyOn(cordova.raw, "create").and.returnValue(Q());
    +            // spyOn(cordova_lib, "CordovaError");
    --- End diff --
    
    do you remember why you commented this out? 


> Update tests to use jasmine instead of jasmine-node
> ---------------------------------------------------
>
>                 Key: CB-12018
>                 URL: https://issues.apache.org/jira/browse/CB-12018
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CLI, CordovaCommon, CordovaJS, CordovaLib, iOS, 
> Plugman
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to