[ 
https://issues.apache.org/jira/browse/CB-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829062#comment-15829062
 ] 

ASF GitHub Bot commented on CB-12366:
-------------------------------------

GitHub user reidab opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/209

    CB-12366: (ios) Reduce tmpWindow level to prevent overlapping statusbar

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Reduces the window level of the `tmpWindow` introduced in #187 to 
`UIWindowLevelNormal`. With the window at `UIWindowLevelAlert`, I'm seeing it 
obscure the iOS status bar when presented.
    
    @manucorporat I'd be curious to know if the higher window level is required 
to solve the issues you were looking at in #187.
    
    ### What testing has been done on this change?
    
    Testing in Simulator iOS 10, Device iOS10.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reidab/cordova-plugin-inappbrowser CB-12366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit 32243b351edb808bd85fa02dc61ecb52d6a3a33a
Author: Reid Beels <[email protected]>
Date:   2017-01-19T00:33:27Z

    CB-12366: (ios) Reduce tmpWindow level to prevent overlapping statusbar

----


> InAppBrowser overlaps iOS status bar
> ------------------------------------
>
>                 Key: CB-12366
>                 URL: https://issues.apache.org/jira/browse/CB-12366
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>            Reporter: Reid Beels
>
> This affects the unreleased 1.6.2-dev (which I can't select from the affects 
> version field).
> Since the change introduced in CB-11136 / 
> https://github.com/apache/cordova-plugin-inappbrowser/pull/187, the IAB 
> window seems to be rendering on top of the iOS status bar.
> Dropping the {{tmpWindow}} window level from {{UIWindowLevelAlert}} to 
> {{UIWindowLevelNormal}} seems to fix the issue, but I'm not sure how this 
> affects the problem CB-11136 set out to solve.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to