[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

Wed, 18 Jan 2017 18:32:54 -0800 

    [ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829191#comment-15829191
 ] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user reidab opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/210

    Ios style improvements

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    I've been working on a branch that brings several visual and configuration 
improvements to the iOS InAppBrowser view, along with a little refactoring of 
the view setup code.
    
    This PR:
    * breaks up the large `CDVInAppBrowserViewController createView` method 
into several smaller helper methods to handle the creation of individual 
subviews
    * gives the `addressLabel` a wrapping view to provide flexibility of 
background color / padding
    * changes the default toolbar style from `UIBarStyleBlackOpaque` to 
`UIBarStyleDefault` to match the system default
    * adds a `toolbarstyle` configuration option that accepts `default` or 
`black`
    * sets the status bar style and background color to match the toolbarstyle, 
so that top toolbars can blend nicely into the status bar
    * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
those used in Safari
    * adds a `tintcolor` configuration option that accepts hex strings like 
`f8a027`. If not provided, or set to `default`, controls will be rendered in 
the default iOS blue, or in white when `toolbarstyle=black` is set.
    
    ### What testing has been done on this change?
    
    Simulator and device iOS 10. Ran plugin auto tests locally.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    ### Screenshots!
    
    #### Old Default
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22090934/093ac000-dda9-11e6-8e95-09ca9929fa68.png";
 width=250>
    
    ---
    
    #### New Default 
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091065/b22beb12-dda9-11e6-8d6c-29b2b5715869.png";
 width=250>
    
    ---
    
    #### `location=no`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091092/ef0b84f2-dda9-11e6-82e8-405aa7ccde9a.png";
 width=250>
    
    ---
    
    #### `location=no,toolbarposition=top`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091124/1bcdd7d8-ddaa-11e6-860b-873c486e627a.png";
 width=250>
    
    ---
    
    #### `location=no,toolbarposition=top,tintcolor=F8A027`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091138/32e9555a-ddaa-11e6-9801-8dd57863f2eb.png";
 width=250>
    
    ---
    
    #### `location=no,toolbarposition=top,tintcolor=F8A027,toolbarstyle=black`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091158/4f9a646e-ddaa-11e6-9201-74f672a1611e.png";
 width=250>
    
    ---
    
    #### `location=no,toolbarposition=top,toolbarstyle=black`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091192/8726d4b2-ddaa-11e6-8462-63f300d840e0.png";
 width=250>
    
    ---
    
    #### `location=no,toolbarstyle=black`
    
    <img 
src="https://cloud.githubusercontent.com/assets/13192/22091204/9ce2720c-ddaa-11e6-9799-bd57497cfbeb.png";
 width=250>
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reidab/cordova-plugin-inappbrowser 
ios-style-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #210
    
----
commit 358c052b1d699f4115e1276d116265171532152d
Author: Reid Beels <[email protected]>
Date:   2017-01-18T05:58:45Z

    CB-12367: (ios) Extract UIWebView setup into buildWebView

commit 19ea6d117fce6d20c4c4bcb1f00169f3db96c751
Author: Reid Beels <[email protected]>
Date:   2017-01-18T06:00:27Z

    CB-12367: (ios) Extract UIActivityIndicatorView setup into buildSpinner

commit 362df5f9764b1073cdc7ffe6579ae378ae4048d3
Author: Reid Beels <[email protected]>
Date:   2017-01-18T06:02:57Z

    CB-12367: (ios) Extract UIToolbar setup into buildToolbar

commit 5d97ab2fbea2c51685db6230953c65d0d746dbf0
Author: Reid Beels <[email protected]>
Date:   2017-01-18T06:05:00Z

    CB-12367: (ios) Extract address UILabel setup into buildAddressLabel

commit ff05f6e1a83a0205851ca776fed990812cc6db15
Author: Reid Beels <[email protected]>
Date:   2017-01-18T06:06:59Z

    CB-12367: (ios) Extract toolbar button setup into separate methods

commit e6c906cdb75a673b25d24b7036678be891e7d78d
Author: Reid Beels <[email protected]>
Date:   2017-01-18T06:27:58Z

    CB-12367: (ios) Allow setting the UIBarStyle of the toolbar to `black` or 
`default`

commit c909fc75e5ecadbaca24697d54ab08acca37acef
Author: Reid Beels <[email protected]>
Date:   2017-01-18T08:02:30Z

    CB-12367: (ios) Replace arrow strings with iOS 7 style back/forward arrows

commit 63cdd716a5fca5bf2cc20f3b40af6d2e4cdc93b7
Author: Reid Beels <[email protected]>
Date:   2017-01-18T09:25:37Z

    CB-12367: (ios) Set the status bar background style to match the toolbar 
style

commit e86bf9d16017c55891e8f63f426d045682186a30
Author: Reid Beels <[email protected]>
Date:   2017-01-18T09:26:01Z

    CB-12367: (ios) Set the status bar style to match the toolbar style

commit 744ebdbec58795eb9675fd12efe1e0a5189aaf71
Author: Reid Beels <[email protected]>
Date:   2017-01-18T18:07:04Z

    CB-12367: (ios) Set toolbar tint color to white if toolbar is dark

commit 068160d892f81d7ee371a70c2c9c19a8b2a500f9
Author: Reid Beels <[email protected]>
Date:   2017-01-18T23:35:06Z

    CB-12367: (ios) Don't subtract toolbar height from webview height
    
    We want the toolbar to overlap for a glassy blur

commit 0ffa32a779a0ed5a2ba18f3b170752339f01e0c9
Author: Reid Beels <[email protected]>
Date:   2017-01-19T00:14:20Z

    CB-12367: (ios) Wrap addressLabel in a UIView to handle inset/background

commit 904ca968cdb37187fc3e998c2ef0566990b448f4
Author: Reid Beels <[email protected]>
Date:   2017-01-19T01:12:24Z

    CB-12367: (ios) Allow setting the view's tint color via `tintcolor=00ff00`

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to