[
https://issues.apache.org/jira/browse/CB-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829791#comment-15829791
]
ASF GitHub Bot commented on CB-12353:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/249
CB-12353 Corrected merges usage in plugin.xml
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Use runs instead of merges to prevent proxy overriding by another plugin
(see details in the [Jira
issue](https://issues.apache.org/jira/browse/CB-12353))
### What testing has been done on this change?
Run auto and manual tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-camera CB-12353
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit fb89a7d1c3f46869949e633b9e4aa869d8fd553e
Author: daserge <[email protected]>
Date: 2017-01-18T16:18:27Z
CB-12353 Corrected merges usage in plugin.xml
----
> UWP - splashscreen is not hidden.
> ---------------------------------
>
> Key: CB-12353
> URL: https://issues.apache.org/jira/browse/CB-12353
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Affects Versions: 4.0.0, 4.0.1
> Environment: cordova-windows 4.4.3 , cordova-plugin-splashscreen
> 4.0.0, Win10 UWP.
> Reporter: Ali Mustafa
> Labels: reproduced, triaged, windows
>
> plugin hide() doesn't hide splashscreen in windows phone 10.
> tried updating both cordova-windows to latest master and
> cordova-plugin-splashscreen to 4.0.1 and still seeing this.
> following a little debugging I did, it seems like hide() in splashscreen.js
> function isn't beeing called and therefore 'hidden' class isn't added to the
> extendedsplashscreen div.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
