[
https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837471#comment-15837471
]
ASF GitHub Bot commented on CB-12383:
-------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97741534
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi, pluginInfoProvider
// instead of generating intermediate file on FS
var cordova_plugins = new Readable();
cordova_plugins.push(
- 'module.exports.metadata = ' + JSON.stringify(pluginMetadata,
null, 4) + ';\n' +
- 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4)
+ ';\n', 'utf8');
+ 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4)
+ ';\n' +
+ 'module.exports.metadata = ' + JSON.stringify(pluginMetadata,
null, 4) + ';\n', 'utf8');
--- End diff --
Right. And the behavior differs for normal and browserify cases.
I.e. in normal case when we are injecting a script element the above code
did not result in `module.exports` being overwritten.
> [Windows] App crashes with --browserify and SplashScreen plugin
> ---------------------------------------------------------------
>
> Key: CB-12383
> URL: https://issues.apache.org/jira/browse/CB-12383
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
