[
https://issues.apache.org/jira/browse/CB-12414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848713#comment-15848713
]
ASF GitHub Bot commented on CB-12414:
-------------------------------------
GitHub user joeljeske opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/29
CB-12414: (iOS) Forward error from provisional load error to standard…
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
It listens for `didFailProvisionalNavigation` errors on the
WKNavigationDelegate and handles them as standard load errors.
`- (void)webView:(WKWebView *)webView
didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError
*)error`
This allows the error page to be shown for all load errors, instead of just
some.
Description
See ticket CB-12414
### What testing has been done on this change?
Manual repro steps as seen in CB-12414 to see that it is fixed.
### Checklist
- [x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joeljeske/cordova-plugin-wkwebview-engine
bug/support-provisional-load-failure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 74045882d6f0aa4aaef93326c903be9d7e65f187
Author: Joel Jeske <[email protected]>
Date: 2017-02-01T17:48:13Z
CB-12414: (iOS) Forward error from provisional load error to standard load
error
----
> WKWebView Engine Plugin not listening for errors on
> didFailProvisionalNavigation
> --------------------------------------------------------------------------------
>
> Key: CB-12414
> URL: https://issues.apache.org/jira/browse/CB-12414
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Reporter: Joel Jeske
> Assignee: Shazron Abdullah
>
> If this plugin is used in a standard iOS Cordova project which <content>
> points to a server that is down or inaccessible, the error page from
> `ErrorUrl` is not loaded as expected.
> Repro:
> * Create iOS Project
> * Add WKWebView Plugin
> * Point <content> to inaccessible server
> * Add preference 'ErrorUrl' to a html file inside the www dir
> * Load the app and see the error page is not loaded
> Versions:
> Cordova 6.4.0
> Cordova iOS 4.3.1
> WKWebView Plugin 1.1.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
