[
https://issues.apache.org/jira/browse/CB-12421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851298#comment-15851298
]
ASF GitHub Bot commented on CB-12421:
-------------------------------------
GitHub user wlmzfx opened a pull request:
https://github.com/apache/cordova-android/pull/357
CB-12421: (android)The CoreAndroid's loadUrl method should load web p…
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Upate CoreAndroid's loadUrl method to load web pages in the UI thread
### What testing has been done on this change?
Built and run the generated application, calling
{color:red}navigator.app.loadUrl('http://domain.com', { "clearHistory":
true}){color} , verify that there is not more errors and navigation can be made
successfully.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-12421: The CoreAndroid's
loadUrl method should load web pages in the UI thread"
- [x] Added automated test coverage as appropriate for this change. (don't
know how?)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wlmzfx/cordova-android CB-12421
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit 4dfbbadae8199c78d89e566a6fc6fdefa58c39b2
Author: Pu Wang <[email protected]>
Date: 2017-02-03T10:15:34Z
CB-12421: (android)The CoreAndroid's loadUrl method should load web pages
in the UI thread
----
> The CoreAndroid's loadUrl method should load web pages in the UI thread
> -----------------------------------------------------------------------
>
> Key: CB-12421
> URL: https://issues.apache.org/jira/browse/CB-12421
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: Master
> Environment: Using android cordova with the crosswalk webview engine:
> https://www.npmjs.com/package/cordova-plugin-crosswalk-webview/
> Reporter: Pu Wang
> Priority: Minor
>
> Calling {color:red}navigator.app.loadUrl('http://domain.com', {
> "clearHistory": true}){color} to open the remote url inside the crosswalk
> webview,
> there will be an error reported at
> {color:red}CordovaWebViewImpl.showWebPage(...){color} method, which is
> requiring the {color:red}engine.clearHistory(){color} method to be run in the
> cordova UI thread.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
