[ 
https://issues.apache.org/jira/browse/CB-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873378#comment-15873378
 ] 

ASF GitHub Bot commented on CB-12317:
-------------------------------------

GitHub user fkoester reopened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25

    CB-12317: Allow to configure navigation by gestures

    ### Platforms affected
    All iOS devices supporting the WKWebView.
    
    ### What does this PR do?
    This PR adds a new configuration option 
`AllowBackForwardNavigationGestures`, which is disabled by default. You can 
enable it in your `config.xml` via:
    
    ```xml
    <preference name="AllowBackForwardNavigationGestures" value="true" />
    ```
    
    Afterwards, the navigation gestures for forward/backward are enabled in the 
WebView (aka "Swipe Navigation").
    
    ### What testing has been done on this change?
    * I tested it without this preference set => swipe navigation disabled like 
before (backwards compatability)
    * I tested it with the preference set to `true` like above => swipe 
navigation enabled. You can swipe back and forward like in Safari.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fkoester/cordova-plugin-wkwebview-engine 
swipe-navigation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 664eb259f5cc5cfebe2e66b399e020c3ed284516
Author: Fabian Köster <[email protected]>
Date:   2016-12-08T09:01:24Z

    Allow to configure navigation by gestures
    
    This adds a new configuration option "AllowBackForwardNavigationGestures":
    
    When enabled, the navigation gestures for forward/backward are enabled (aka 
"Swipe Navigation")

----


> Feature: Allow to configure navigation by gestures
> --------------------------------------------------
>
>                 Key: CB-12317
>                 URL: https://issues.apache.org/jira/browse/CB-12317
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to