[
https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888689#comment-15888689
]
ASF GitHub Bot commented on CB-12016:
-------------------------------------
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103526011
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
if (parsedSpec.id != pinfo.id) {
- var alias = parsedSpec.scope ? null :
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
+ var alias = null;
if (alias !== pinfo.id) {
--- End diff --
kk thanks! @stevengill If you remove this code, there are tests that go
with it and they will fail so I removed those in the next commit. How does this
look?
https://github.com/apache/cordova-lib/pull/522/commits/a29720e6d6b2378d9e342a5b1bb46bef1db17fa8
> remove plugin ID mapping
> ------------------------
>
> Key: CB-12016
> URL: https://issues.apache.org/jira/browse/CB-12016
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, CordovaLib
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> For cordova@7, we can remove the cordova-registry-mapper module and remove
> the automatic plugin mapping we do
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
