[ 
https://issues.apache.org/jira/browse/CB-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893174#comment-15893174
 ] 

ASF GitHub Bot commented on CB-12384:
-------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/289#discussion_r104048113
  
    --- Diff: CordovaLib/CordovaLib.xcodeproj/project.pbxproj ---
    @@ -499,6 +637,105 @@
                        };
                        name = Release;
                };
    +           C0C01EB71E3911D50056E6CB /* Debug */ = {
    +                   isa = XCBuildConfiguration;
    +                   buildSettings = {
    +                           ALWAYS_SEARCH_USER_PATHS = NO;
    +                           ARCHS = "$(ARCHS_STANDARD)";
    +                           CLANG_ANALYZER_NONNULL = YES;
    +                           CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
    +                           CLANG_CXX_LIBRARY = "libc++";
    +                           CLANG_ENABLE_MODULES = YES;
    +                           CLANG_ENABLE_OBJC_ARC = YES;
    +                           CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
    +                           CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
    +                           CLANG_WARN_INFINITE_RECURSION = YES;
    +                           CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    +                           CLANG_WARN_SUSPICIOUS_MOVE = YES;
    +                           CLANG_WARN_UNREACHABLE_CODE = YES;
    +                           CODE_SIGN_IDENTITY = "";
    +                           "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone 
Developer";
    +                           COPY_PHASE_STRIP = NO;
    +                           CURRENT_PROJECT_VERSION = 1;
    +                           DEBUG_INFORMATION_FORMAT = dwarf;
    +                           DEFINES_MODULE = YES;
    +                           DYLIB_COMPATIBILITY_VERSION = 1;
    +                           DYLIB_CURRENT_VERSION = 1;
    +                           DYLIB_INSTALL_NAME_BASE = "@rpath";
    +                           ENABLE_STRICT_OBJC_MSGSEND = YES;
    +                           GCC_C_LANGUAGE_STANDARD = gnu99;
    +                           GCC_DYNAMIC_NO_PIC = NO;
    +                           GCC_NO_COMMON_BLOCKS = YES;
    +                           GCC_PREPROCESSOR_DEFINITIONS = (
    +                                   "DEBUG=1",
    +                                   "$(inherited)",
    +                           );
    +                           GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    +                           GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    +                           GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    +                           INFOPLIST_FILE = Cordova/Info.plist;
    +                           INSTALL_PATH = 
"$(LOCAL_LIBRARY_DIR)/Frameworks";
    +                           IPHONEOS_DEPLOYMENT_TARGET = 8.0;
    +                           LD_RUNPATH_SEARCH_PATHS = "$(inherited) 
@executable_path/Frameworks @loader_path/Frameworks";
    +                           MTL_ENABLE_DEBUG_INFO = YES;
    +                           OTHER_LDFLAGS = "-all_load";
    +                           PRODUCT_BUNDLE_IDENTIFIER = 
com.apache.cordova.Cordova;
    +                           PRODUCT_NAME = "$(TARGET_NAME)";
    +                           PUBLIC_HEADERS_FOLDER_PATH = 
"$(CONTENTS_FOLDER_PATH)/Headers";
    +                           SKIP_INSTALL = YES;
    +                           VERSIONING_SYSTEM = "apple-generic";
    +                           VERSION_INFO_PREFIX = "";
    +                   };
    +                   name = Debug;
    +           };
    +           C0C01EB81E3911D50056E6CB /* Release */ = {
    +                   isa = XCBuildConfiguration;
    +                   buildSettings = {
    +                           ALWAYS_SEARCH_USER_PATHS = NO;
    +                           ARCHS = "$(ARCHS_STANDARD)";
    +                           CLANG_ANALYZER_NONNULL = YES;
    +                           CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
    +                           CLANG_CXX_LIBRARY = "libc++";
    +                           CLANG_ENABLE_MODULES = YES;
    +                           CLANG_ENABLE_OBJC_ARC = YES;
    +                           CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
    +                           CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
    +                           CLANG_WARN_INFINITE_RECURSION = YES;
    +                           CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    +                           CLANG_WARN_SUSPICIOUS_MOVE = YES;
    +                           CLANG_WARN_UNREACHABLE_CODE = YES;
    +                           CODE_SIGN_IDENTITY = "";
    +                           "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone 
Developer";
    +                           COPY_PHASE_STRIP = NO;
    +                           CURRENT_PROJECT_VERSION = 1;
    +                           DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
    +                           DEFINES_MODULE = YES;
    +                           DYLIB_COMPATIBILITY_VERSION = 1;
    +                           DYLIB_CURRENT_VERSION = 1;
    +                           DYLIB_INSTALL_NAME_BASE = "@rpath";
    +                           ENABLE_NS_ASSERTIONS = NO;
    +                           ENABLE_STRICT_OBJC_MSGSEND = YES;
    +                           GCC_C_LANGUAGE_STANDARD = gnu99;
    +                           GCC_NO_COMMON_BLOCKS = YES;
    +                           GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    +                           GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    +                           GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    +                           INFOPLIST_FILE = Cordova/Info.plist;
    +                           INSTALL_PATH = 
"$(LOCAL_LIBRARY_DIR)/Frameworks";
    +                           IPHONEOS_DEPLOYMENT_TARGET = 8.0;
    +                           LD_RUNPATH_SEARCH_PATHS = "$(inherited) 
@executable_path/Frameworks @loader_path/Frameworks";
    +                           MTL_ENABLE_DEBUG_INFO = NO;
    +                           OTHER_LDFLAGS = "-all_load";
    +                           PRODUCT_BUNDLE_IDENTIFIER = 
com.apache.cordova.Cordova;
    --- End diff --
    
    use `org.apache.cordova.Cordova` instead


> Add Cordova framework target to iOS
> -----------------------------------
>
>                 Key: CB-12384
>                 URL: https://issues.apache.org/jira/browse/CB-12384
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaLib, iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>            Assignee: Shazron Abdullah
>             Fix For: [email protected]
>
>   Original Estimate: 40h
>  Remaining Estimate: 40h
>
> Carthage support requires a dynamic framework target for Cordova.  It should 
> be possible to create a framework target that lives side by side with the 
> existing static library target (CordovaLib), sharing code, tests, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to