[
https://issues.apache.org/jira/browse/CB-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900318#comment-15900318
]
ASF GitHub Bot commented on CB-12524:
-------------------------------------
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/365
CB-12524: Fix the GradleBuilder so that it builds the project with an
included Gradle
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR adds the Gradle Wrapper for the Cordova Framework and uses it for
all projects. This has been added after the recent changes Google has made to
the Android SDK tools from 25.3.1.
### What testing has been done on this change?
Tested the build.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-android android_sdk_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #365
----
----
> add plugin failing because it cannot find tools/templates
> ---------------------------------------------------------
>
> Key: CB-12524
> URL: https://issues.apache.org/jira/browse/CB-12524
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, App Hello World
> Affects Versions: 6.5.0
> Environment: Mac OSX 10.12.3
> Cordova 6.5.0
> Android 6.1.2
> Reporter: Gary N Griswold
> Assignee: Joe Bowser
> Priority: Blocker
>
> plugin add is failing because it is looking for in
> sdk/tools/templates/gradle/wrapper, but tools/templates does not exist.
> The reference to the missing templates directory is found in
> {quote}check_reqs.js line 88{quote}
> {code}
> platforms/android/cordova/lib/check_reqs.js
> line 88: var wrapperDir = path.join(sdkDir, 'tools', 'templates', 'gradle',
> 'wrapper');
> Please see the
> cordova plugin add $HOME/<local file spec>
> Failed to install 'com-shortsands-videoplayer':CordovaError: Could not find
> gradle wrapper within Android SDK. Might need to update your Android SDK.
> Looked here:
> /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
> at Object.module.exports.check_gradle
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/check_reqs.js:90:25)
> at GradleBuilder.prepEnv
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/builders/GradleBuilder.js:161:23)
> at Api.module.exports.runClean
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/build.js:131:20)
> at
> /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/Api.js:394:50
> at _fulfilled
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:834:54)
> at self.promiseDispatch.done
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:863:30)
> at Promise.promise.promiseDispatch
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:796:13)
> at
> /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:604:44
> at runSingle
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:125:13)
> Error: Could not find gradle wrapper within Android SDK. Might need to update
> your Android SDK.
> Looked here:
> /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
