[
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925151#comment-15925151
]
ASF GitHub Bot commented on CB-12571:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/296
CB-12571 - Podfile gets overwritten and some dependencies disappear.
### Platforms affected
self
### What does this PR do?
Fix adding of pods with non-alphanumeric characters in the name to Podfile
### What testing has been done on this change?
Added unit tests
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12571
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 514b3f1917a8079e3e24f0b2a4163478b437b309
Author: Shazron Abdullah <[email protected]>
Date: 2017-03-14T22:17:09Z
CB-12571 - Podfile gets overwritten and some dependencies disappear.
----
> Podfile gets overwriten and some dependencies disappear
> -------------------------------------------------------
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: jcesarmobile
> Assignee: Shazron Abdullah
> Labels: cordova-ios
> Fix For: [email protected]
>
>
> When you install some plugins that use CocoaPods, some of the libraries
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is
> there
> 6. cordova plugin add
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~>
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both
> pod 'AeroGear-Push', '1.2.0'
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found
> this two plugins where the problem is present, but it was also reported on
> Slack.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
