[
https://issues.apache.org/jira/browse/CB-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927093#comment-15927093
]
ASF GitHub Bot commented on CB-12572:
-------------------------------------
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-lib/pull/528
CB-12572: (windows) pin cordova-windows 5.0.0
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
[CB-12572](https://issues.apache.org/jira/browse/CB-12572): use
cordova-windows 5.0.0
This is needed to support Windows plugin WinMD+DLL combinations
([CB-12189](https://issues.apache.org/jira/browse/CB-12189)).
### What testing has been done on this change?
- Install cordova-lib with this change in a local checkout of cordova-cli
- Do npm install of the local cordova-cli in a test directory
- Use the local cordova-cli to add the Windows platform to a local checkout
of <https://github.com/brodybits/cordova-dialogs-bootstrap-test>
- do `cordova platform ls` to verify that cordova-windows 5.0.0 was used
- Build and run as both desktop and mobile app (using Visual Studio 2015)
I do not think there is any need to update the automatic test suite. Please
correct me in case I am mistaken.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] ~~Added automated test coverage as appropriate for this change.~~
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-lib cb-12572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #528
----
commit 391f23745be27633c6afadae227f275682699cf0
Author: Christopher J. Brody <[email protected]>
Date: 2017-03-15T22:02:28Z
CB-12572: (windows) pin cordova-windows 5.0.0
----
> Pin cordova-windows 5.0.0
> -------------------------
>
> Key: CB-12572
> URL: https://issues.apache.org/jira/browse/CB-12572
> Project: Apache Cordova
> Issue Type: Task
> Components: CLI, CordovaLib
> Reporter: Chris Brody
>
> The cordova-windows 5.0.0 release is needed to support plugin WinMD+DLL
> combinations (CB-12189). As discussed in
> https://forums.adobe.com/thread/2271279 this needs to be included by Cordova
> CLI before it is supported by PhoneGap CLI and PhoneGap Build.
> ADDITIONAL NOTE: This is needed in both cordova-lib & cordova-cli.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
