[
https://issues.apache.org/jira/browse/CB-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929153#comment-15929153
]
ASF GitHub Bot commented on CB-12577:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/298
CB-12577 - Fix module import warnings when using Cordova.framework
(Carthage)
### Platforms affected
self
### What does this PR do?
Remove warnings related to incomplete umbrella headers when using `@import
Cordova` after compiling Cordova.framework using Carthage.
### What testing has been done on this change?
Added Cordova.framework from the repo using Carthage, added the import,
added a reference to CDVViewController, and built an iOS View app.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit c7b422c5bd7a45e37df5945ca336bab58a1263a2
Author: Shazron Abdullah <[email protected]>
Date: 2017-03-16T23:35:02Z
CB-12577 - Fix module import warnings when using Cordova.framework
(Carthage)
----
> Fix module import warnings when using Cordova.framework (Carthage)
> ------------------------------------------------------------------
>
> Key: CB-12577
> URL: https://issues.apache.org/jira/browse/CB-12577
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Fix For: [email protected]
>
> Attachments: moduleimport.png
>
>
> When adding {{Cordova.framework}} after adding and building it using
> Carthage, and using module import:
> {code}
> @import Cordova;
> {code}
> then adding this to my code and building:
> {code}
> CDVViewController* cdv = [CDVViewController new];
> {code}
> I get two lexical or preprocessor issue warnings:
> {code}
> <module-includes>:1:1: warning: umbrella header for module 'Cordova' does not
> include header 'CDV.h' [-Wincomplete-umbrella]
> #import "Headers/Cordova.h"
> ^
> <module-includes>:1:1: warning: umbrella header for module 'Cordova' does not
> include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
> 2 warnings generated.
> /Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24:
> warning: unused variable 'c' [-Wunused-variable]
> CDVViewController* c = [CDVViewController new];
> ^
> 3 warnings generated.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
