[
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931877#comment-15931877
]
ASF GitHub Bot commented on CB-10893:
-------------------------------------
Github user duchuyctlk commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r106814440
--- Diff: src/android/SplashScreen.java ---
@@ -313,6 +315,22 @@ public void run() {
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
--- End diff --
`splashDialog.getWindow()` is repeatedly used, so i think it could be
extracted into a variable to avoid multiple method calls.
> Allow setting status bar color on Android splashscreen
> ------------------------------------------------------
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin SplashScreen
> Environment: Android
> Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar
> background color.
> The splash screen doesn't seem to use the application's theme - the status
> bar becomes black while displaying the splash screen image (no matter which
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash
> screen image is displayed. Alternatively, inherit the application's status
> bar settings.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
