[
https://issues.apache.org/jira/browse/CB-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933383#comment-15933383
]
ASF GitHub Bot commented on CB-12588:
-------------------------------------
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/14
Add manual tests
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
Please review @purplecabbage and @maverickmishra.
### Platforms affected
All.
### What does this PR do?
Adds manul tests in the style of [cordova-plugin-test-framework's manual
tests](https://github.com/apache/cordova-plugin-test-framework#defining-manual-tests).
### What testing has been done on this change?
Tested on an Android 7.1 emulator and on an iOS 10.2 simulator, using
[cordova-mobile-spec's `createmobilespec`
helper](https://github.com/apache/cordova-mobile-spec/tree/master/createmobilespec).
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database:
[CB-12588](https://issues.apache.org/jira/browse/CB-12588).
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-plugin-screen-orientation
CB-12588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit f12721b35e8f48599d1698ead85eaf707b8532fa
Author: filmaj <maj....@gmail.com>
Date: 2017-03-20T19:36:50Z
CB-12588: add manual tests in cordova-plugin-test-framework style
----
> Add manual tests for cordova-plugin-screen-orientation
> ------------------------------------------------------
>
> Key: CB-12588
> URL: https://issues.apache.org/jira/browse/CB-12588
> Project: Apache Cordova
> Issue Type: Test
> Components: Plugin Screen Orientation
> Reporter: Filip Maj
> Assignee: Filip Maj
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
