[ 
https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977874#comment-15977874
 ] 

ASF GitHub Bot commented on CB-12015:
-------------------------------------

GitHub user macdonst opened a pull request:

    https://github.com/apache/cordova-android/pull/376

    Fix for CB-12015: initial-scale values less than 1.0 are ignored on Android

    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    Fixed an issue where the meta tag viewport is ignored if scaling is less 
than 1.0.
    
    ### What testing has been done on this change?
    
    I tested it on a couple of devices running Android 5.0 and 6.0.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/macdonst/cordova-android cb12015

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #376
    
----
commit c06b96cd4562b228b015b6cbebd8e0948744d2db
Author: Simon MacDonald <simon.macdon...@gmail.com>
Date:   2017-04-21T00:41:54Z

    CB-12015: initial-scale values less than 1.0 are ignored on Android

----


> initial-scale values less than 1.0 are ignored on Android
> ---------------------------------------------------------
>
>                 Key: CB-12015
>                 URL: https://issues.apache.org/jira/browse/CB-12015
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: cordova-android@5.2.2
>            Reporter: Simon MacDonald
>
> So, the way cordova-android is right now if I use:
>     <meta name="viewport" content="user-scalable=no, initial-scale=1.0" />
> Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes 
> everything bigger. However, setting:
>     <meta name="viewport" content="user-scalable=no, initial-scale=0.5" />
> has no effect whatsoever.
> Going into the SystemWebViewEngine class and adding:
>     settings.setUseWideViewPort(true);
>     settings.setLoadWithOverviewMode(true);
> to initWebViewSettings() method then allows me to scale the viewport down. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to