[ 
https://issues.apache.org/jira/browse/CB-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978612#comment-15978612
 ] 

Sergii Stotskyi commented on CB-12682:
--------------------------------------

it'd even better to provide different error classes for different situations. 
Like {{Camera.CancelError}} for canceling, {{Camera.Error}} for unrecoverable 
error, {{Camera.AccessError}} for permissions issue, 
{{Camera.NotSupportedError}} for cases when device doesn't have camera at all. 
But I think it will be a matter of a separate improvement.

But I'd like to understand whether you guys think it worth to change this. I my 
opinion it worth as it will allow to detect errors based on types, not based on 
strings (which I think is fragile)

> Consistent cancel message between iOS and Android
> -------------------------------------------------
>
>                 Key: CB-12682
>                 URL: https://issues.apache.org/jira/browse/CB-12682
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>    Affects Versions: 2.4.0
>            Reporter: Sergii Stotskyi
>              Labels: ios
>
> Currently when user taps on "Cancel" button in camera modal plugin, returns 
> inconsistent error message.
> For iOS it returns: no image selected
> For Android: Camera cancelled
> I'd like it to be consistent as it will simplify check of whether it's cancel 
> error or other errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to