[ 
https://issues.apache.org/jira/browse/CB-12705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984266#comment-15984266
 ] 

ASF GitHub Bot commented on CB-12705:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/549
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=h1) 
Report
    > Merging 
[#549](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/52d2a75cf11096909d71554cce47092043835711?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
    > The diff coverage is `100%`.
    
    [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/549/graphs/tree.svg?height=150&width=650&token=KwBjKMXLqA&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #549      +/-   ##
    ==========================================
    + Coverage   83.32%   83.32%   +<.01%     
    ==========================================
      Files          65       65              
      Lines        5175     5176       +1     
      Branches     1033     1034       +1     
    ==========================================
    + Hits         4312     4313       +1     
      Misses        863      863
    ```
    
    
    | [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=tree) | 
Coverage Δ | |
    |---|---|---|
    | 
[cordova-lib/src/hooks/HooksRunner.js](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2hvb2tzL0hvb2tzUnVubmVyLmpz)
 | `74.04% <100%> (+0.19%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=continue).
    > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=footer). 
Last update 
[52d2a75...7a947c0](https://codecov.io/gh/apache/cordova-lib/pull/549?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Project *_plugin_install hooks don't have information on installed plugin
> -------------------------------------------------------------------------
>
>                 Key: CB-12705
>                 URL: https://issues.apache.org/jira/browse/CB-12705
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-cli, CordovaLib
>    Affects Versions: 6.5.0
>            Reporter: Fabian Eichinger
>
> I want to build a {{after_plugin_install}} javascript hook for my project 
> that only executes it logic when installing a specific plugin (in my case 
> {{cordova-plugin-file}}). As it turns out the context passed to project-level 
> {{\*_plugin_install}} hooks do not contain *any* information on the plugin 
> that was installed and this makes these kind of hooks basically useless.
> I propose passing to them the same information in {{context.opts.plugin}} as 
> to plugin hooks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to