[
https://issues.apache.org/jira/browse/CB-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984916#comment-15984916
]
ASF GitHub Bot commented on CB-12146:
-------------------------------------
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
Hmm, looks like all three CI runs against Android (4.4, 5.1, and 6.0)
failed. Output for these three test runs:
- Android 4.4:
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/121/PLATFORM=android-4.4/console
- Android 5.1:
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/121/PLATFORM=android-5.1/
- Android 6.0:
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/121/PLATFORM=android-6.0/
All three fail because of a missing import, `PermissionHelper`, which you
removed in your PR:
```
Error:
/private/var/folders/nd/5vd2nqsn3tlc6kljds0c95200000gp/T/tmp-8821EyOxfsP58Sxv/platforms/android/gradlew:
Command failed with exit code 1 Error output:
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/private/var/folders/nd/5vd2nqsn3tlc6kljds0c95200000gp/T/tmp-8821EyOxfsP58Sxv/platforms/android/src/org/apache/cordova/media/AudioHandler.java:83:
error: cannot find symbol
PermissionHelper.requestPermission(this, requestCode,
permissions[WRITE_EXTERNAL_STORAGE]);
^
symbol: variable PermissionHelper
location: class AudioHandler
```
We cannot accept this PR if it causes Cordova apps that add the plugin to
not be able to compile.
> cordova-plugin-media - Adds support for "playAudioWhenScreenIsLocked" already
> used in iOS
> -----------------------------------------------------------------------------------------
>
> Key: CB-12146
> URL: https://issues.apache.org/jira/browse/CB-12146
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Media
> Affects Versions: Master
> Environment: Apache Cordova media plugin on Android
> Reporter: Romedius Weiss
> Priority: Minor
> Labels: newbie, patch
> Fix For: Master
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch adds the support of the playAudioWhenScreenIsLocked flag on
> Android, listed as quirk for iOS.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/#ios-quirks
> A previous version of the fix was published here:
> https://github.com/apache/cordova-plugin-media/pull/54
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
