[jira] [Commented] (CB-11242) The platform-specific code for platforms w/ PlatformApi implemented should be removed in the next major release

Sat, 29 Apr 2017 14:18:16 -0700 

    [ 
https://issues.apache.org/jira/browse/CB-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990042#comment-15990042
 ] 

ASF GitHub Bot commented on CB-11242:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/551
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=h1) 
Report
    > Merging 
[#551](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/7451fc638c8e98420fce2611a3726c71b245da24?src=pr&el=desc)
 will **decrease** coverage by `2.37%`.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/551/graphs/tree.svg?token=KwBjKMXLqA&src=pr&width=650&height=150)](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #551      +/-   ##
    ==========================================
    - Coverage   81.86%   79.49%   -2.38%     
    ==========================================
      Files          65       57       -8     
      Lines        5179     3945    -1234     
      Branches     1033      830     -203     
    ==========================================
    - Hits         4240     3136    -1104     
    + Misses        939      809     -130
    ```
    
    
    | [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree) | 
Coverage Δ | |
    |---|---|---|
    | 
[cordova-lib/src/plugman/platforms/common.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2NvbW1vbi5qcw==)
 | `84.21% <0%> (-9.48%)` | :arrow_down: |
    | 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `84.59% <0%> (-3.94%)` | :arrow_down: |
    | 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `91.47% <0%> (-2.33%)` | :arrow_down: |
    | 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `74.58% <0%> (-0.7%)` | :arrow_down: |
    | 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.05% <0%> (-0.22%)` | :arrow_down: |
    | 
[cordova-lib/src/plugman/util/android-project.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vdXRpbC9hbmRyb2lkLXByb2plY3QuanM=)
 | | |
    | 
[cordova-lib/src/cordova/metadata/windows\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbWV0YWRhdGEvd2luZG93c19wYXJzZXIuanM=)
 | | |
    | 
[cordova-lib/src/plugman/platforms/android.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2FuZHJvaWQuanM=)
 | | |
    | 
[cordova-lib/src/util/windows/jsprojManager.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvd2luZG93cy9qc3Byb2pNYW5hZ2VyLmpz)
 | | |
    | 
[cordova-lib/src/plugman/platforms/windows.js](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL3dpbmRvd3MuanM=)
 | | |
    | ... and [7 
more](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=continue).
    > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=footer). 
Last update 
[7451fc6...ba03f52](https://codecov.io/gh/apache/cordova-lib/pull/551?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> The platform-specific code for platforms w/ PlatformApi implemented should be 
> removed in the next major release
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-11242
>                 URL: https://issues.apache.org/jira/browse/CB-11242
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to