[
https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005505#comment-16005505
]
ASF GitHub Bot commented on CB-12397:
-------------------------------------
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/19
CB-12397 fix .gitignore for plugins & platforms
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All
### What does this PR do?
Add `plugins` and `platforms` to `.gitignore` to resolve [Apache Cordova
CB-12397](https://issues.apache.org/jira/browse/CB-12397), now working if
properly integrated with apache/cordova-create#8 (workaround solution to
[Apache Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397) in
`cordova-create`).
### What testing has been done on this change?
As described in <https://github.com/apache/cordova-create/pull/8>: tested
using local installation of
<https://github.com/brodybits/cordova-cli/tree/cb-12397-devtest1>.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
**NOT RELEVANT in this PR:**
- ~~Added automated test coverage as appropriate for this change.~~
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-app-hello-world cb-12397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-app-hello-world/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit f7c85137256e050856e8fe9341ed3b2ba0c319f1
Author: Christopher J. Brody <[email protected]>
Date: 2017-05-09T13:11:49Z
CB-12397 fix .gitignore for plugins & platforms
----
> fix .gitignore for plugins & platforms in app template
> ------------------------------------------------------
>
> Key: CB-12397
> URL: https://issues.apache.org/jira/browse/CB-12397
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world, cordova-cli, cordova-create,
> cordova-lib
> Reporter: Chris Brody
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an
> app using "cordova create" there should be a .gitignore file to exclude the
> plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins /
> platforms artifacts included in git.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
