[ 
https://issues.apache.org/jira/browse/CB-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019389#comment-16019389
 ] 

ASF GitHub Bot commented on CB-12685:
-------------------------------------

GitHub user davidschreiber opened a pull request:

    https://github.com/apache/cordova-plugin-test-framework/pull/24

    Add important build step about packages.json

    This step is necessary or tests won't build. The original issue that fixed 
this issue in all Cordova projects is was only closed recently, but the 
information was missing in this repository: 
https://issues.apache.org/jira/browse/CB-12685

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidschreiber/cordova-plugin-test-framework 
patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-test-framework/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit ec8c77eaf39e53f03b37f4ac68f5abe45634f19c
Author: David Schreiber-Ranner <[email protected]>
Date:   2017-05-22T09:53:56Z

    Add important build step
    
    This step is necessary or tests won't build. The original issue that fixed 
this issue in all cordova projects is was only closed recently, but the 
information was missing in this repository: 
https://issues.apache.org/jira/browse/CB-12685

----


> add package.json to test directories of all of our plugins
> ----------------------------------------------------------
>
>                 Key: CB-12685
>                 URL: https://issues.apache.org/jira/browse/CB-12685
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugins
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>
> Cordova-fetch requires plugins to have a package.json file when installing. 
> Our test plugins living in all of our core plugins do not have package.json 
> files. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to