[
https://issues.apache.org/jira/browse/CB-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028381#comment-16028381
]
ASF GitHub Bot commented on CB-12804:
-------------------------------------
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/30#discussion_r118941014
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,40 @@ Api.createPlatform = function (dest, config, options,
events) {
events.emit('error','createPlatform is not callable from the
browser project API.');
throw(e);
}
+
+ // Create manifest.json
+ var manifestJson;
+ var manifestJsonPath = path.join(dest,'manifest.json');
+
+ // Check if path exists and require manifestJsonPath.
+ if(fs.existsSync(manifestJsonPath)) {
+ try {
+ manifestJson = require(manifestJsonPath);
+ }
+ catch (e) {
+ console.log("error : " + e);
+ events.emit('error', 'unable to require manifest.json path.');
+ }
+ } else if (manifestJson === undefined) {
+ manifestJson = {};
+ if(config){
+ if(config.name()) {
+ manifestJson.name = config.name();
+ }
--- End diff --
We should add short name as well.
```
manifestJson.short_name = config.shortName();
```
> Cordova-browser PWA needs a manifest file
> -----------------------------------------
>
> Key: CB-12804
> URL: https://issues.apache.org/jira/browse/CB-12804
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-browser
> Reporter: Audrey So
> Assignee: Audrey So
> Fix For: cordova7
>
>
> Cordova-browser PWA needs a manifest file.
> This manifest.json file should get created during cordova platform add
> browser and use values from config.xml to build.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
