[
https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052448#comment-16052448
]
ASF GitHub Bot commented on CB-12895:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/386
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=h1)
Report
> Merging
[#386](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr&el=desc)
will **increase** coverage by `2.18%`.
> The diff coverage is `51.13%`.
[](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
=========================================
+ Coverage 39.52% 41.7% +2.18%
=========================================
Files 16 16
Lines 1551 1489 -62
Branches 277 278 +1
=========================================
+ Hits 613 621 +8
+ Misses 938 868 -70
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
| `37.5% <0%> (+4.16%)` | :arrow_up: |
|
[bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==)
| `15.38% <0%> (ø)` | :arrow_up: |
|
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
| `94.73% <100%> (ø)` | :arrow_up: |
|
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
| `35.13% <100%> (-0.87%)` | :arrow_down: |
|
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
| `20.43% <20.93%> (+0.43%)` | :arrow_up: |
|
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
| `22.44% <26.31%> (+4.26%)` | :arrow_up: |
|
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
| `13.43% <31.57%> (+3.08%)` | :arrow_up: |
|
[bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=)
| `34.14% <33.33%> (+3.03%)` | :arrow_up: |
|
[bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=)
| `26.98% <37.5%> (+9.07%)` | :arrow_up: |
|
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
| `40.81% <41.93%> (+2.47%)` | :arrow_up: |
| ... and [6
more](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=footer).
Last update
[3a6e898...875ea35](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Replace jshint with eslint in our tools + platforms
> ---------------------------------------------------
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllComponents
> Reporter: Steve Gill
> Assignee: Audrey So
> Priority: Minor
> Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
> +
> +I suggest to replace the current style checkers with ESLint. This allows to
> set much more strict styling rules than at at this moment.
> +
> +I recommend using a popular preset, such as
> [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base).
> Example configuration:
> +
> +```yaml
> +root: true
> +
> +extends: airbnb-base
> +```
> +
> +Many styling issues could be fixed by simply running:
> +
> +```
> +./node_modules/.bin/eslint --fix .
> +```
> +
> +
> +
> +Optionally the indent could be set to 4 instead of 2, because that's used
> in the current code base.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
