ASF GitHub Bot commented on CB-12367:

Github user shazron commented on the issue:

    Thank you for the PR.
    Since this is only adding a feature (tintcolor), and changing behaviour of 
a feature (toolbarstyle), the version should be bumped a minor to 1.8.0. (we 
follow semver). No breaking changes thus this is not a major version bump.
    I would have to test this on an iPad before I can merge it in.

> Modernize styling of iOS InAppBrowser view
> ------------------------------------------
>                 Key: CB-12367
>                 URL: https://issues.apache.org/jira/browse/CB-12367
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-inappbrowser
>    Affects Versions: 1.6.1
>            Reporter: Reid Beels
> I've been working on a branch that brings several visual and configuration 
> improvements to the iOS InAppBrowser view, along with a little refactoring of 
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method 
> into several smaller helper methods to handle the creation of individual 
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of 
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to 
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or 
> {{black}}
> * sets the status bar style and background color to match the 
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like 
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered 
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to