[
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061443#comment-16061443
]
ASF GitHub Bot commented on CB-11244:
-------------------------------------
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123834608
--- Diff: bin/lib/create.js ---
@@ -314,7 +340,18 @@ exports.update = function(projectPath, options,
events) {
return Q()
.then(function() {
- var manifest = new AndroidManifest(path.join(projectPath,
'AndroidManifest.xml'));
+ var isAndroidStudio =
AndroidStudio.isAndroidStudioProject(projectPath);
+ var isLegacy = !isAndroidStudio;
+ var manifest = null;
+ var builder = 'gradle';
+
+ if(isAndroidStudio) {
+ manifest = new AndroidManifest(path.join(projectPath, 'app',
'main', 'AndroidManifest.xml'));
+ builder = 'studio';
+ } else {
+ manifest = new AndroidManifest(path.join(projectPath,
'AndroidManifest.xml'));
+ builder = 'gradle';
+ }
--- End diff --
Same thing here, this may be better folded up into the Builders?
> Update Android Project Structure to be more compatible with Android Studio
> --------------------------------------------------------------------------
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project
> structure created by default, even for new projects, which makes no sense
> since we no longer support Eclipse as the default project editor and have
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for
> projects and dependencies to work more like how modern Android projects work
> and to remove as much custom Gradle code as possible. This would also allow
> us in the future to move towards having Android Plugin code work as Android
> Libraries with Resources instead of just copying things across, which gives
> us the ability to add JUnit tests and bundled resources. This would
> dramatically increase the quality of plugins such as InAppBrowser, and third
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would
> be tricky to do. However, the benefits at this point would greatly outweigh
> the costs of maintaining the old project structure. The old cordova-common
> code in Cordova-Android 5.0.x would allow for plugins in the short term to
> work with both projects until we get the new project structure ready.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
