[
https://issues.apache.org/jira/browse/CB-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061719#comment-16061719
]
ASF GitHub Bot commented on CB-12948:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/322
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=h1)
Report
> Merging
[#322](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/4490abf273ec6d12810c8ff5ea16d197c58ecd4b?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 14 14
Lines 1623 1623
Branches 277 277
=======================================
Hits 1035 1035
Misses 588 588
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=footer).
Last update
[4490abf...4fbaebd](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Add a warning to updateProject for iOS
> --------------------------------------
>
> Key: CB-12948
> URL: https://issues.apache.org/jira/browse/CB-12948
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Fix For: [email protected]
>
>
> Right now a `cordova platform update` (CLI) or update scripts (non-CLI) will
> treat platforms as a build artifact.
> They use the same function:
> https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/lib/create.js#L261-L273
> There is no warning to the user at all. We should:
> 1. Add a warning but don't do the update
> 2. The warning has an instruction on how to override the warning and do the
> update (new flag?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
