Joshua Bronson created CB-12952:
-----------------------------------

             Summary: Fall back to using configured splash screen of matching 
dimensions and opposite orientation when available, rather than default Cordova 
splash screen
                 Key: CB-12952
                 URL: https://issues.apache.org/jira/browse/CB-12952
             Project: Apache Cordova
          Issue Type: Bug
          Components: cordova-plugin-splashscreen
            Reporter: Joshua Bronson
            Priority: Minor


h2. Minimal reproduction steps:

(For the sake of brevity, the following assumes you are targeting iPhone 6, 6s, 
or 7, but a similar procedure can be followed to reproduce on other devices.)

# Set up a cordova project with the iOS platform, cordova-plugin-splashscreen, 
and add e.g. {{<splash src="res/screen/ios/Default-667h.png" width="750" 
height="1334"/>}} to your config.xml, where "res/screen/ios/Default-667h.png" 
is the path to your custom splash screen image with the dimensions indicated / 
matching your device.
# Launch the app on the device while the screen is in *landscape* orientation.


h2. Current Result

Cordova's default splash screen is used.


h2. Expected Result

The splash screen specified in config.xml is used, just as it would have been 
if the screen had been in portrait orientation when the app was launched.

h1. Rationale

It is strictly preferable (and better aligned with the intent of the developer 
and expectations of the user) to show the same splash screen in landscape 
orientation that is shown in portrait orientation, even though the orientation 
won't match, compared to showing the default Cordova splash screen in the 
landscape orientation.

It's easy for developers to not realize what the current behavior is, because 
1. they followed the plugin's documentation, which doesn't warn about this 
behavior clearly, even though it's totally a "gotcha", and 2. developers often 
don't think to test in landscape mode, so never encounter this before releasing 
to users. Then everyone gets an unpleasant surprise when they realize this has 
been happening in production.

Any interest in adding logic to fall back to using a configured splash screen 
of matching dimensions and opposite orientation, when available, rather than 
the default Cordova splash screen?


h3. Impact

I've only encountered this while testing on an iOS device and using the 
https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/#legacy-launch-images
 method, but it may occur on other platforms and configurations too.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to