[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064023#comment-16064023
]
ASF GitHub Bot commented on CB-12361:
-------------------------------------
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/570
CB-12361 : updated cordova-lib addHelper.spec tests
Not ready to be merged/reviewed yet! Thank you!
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Updated cordova-lib addHelper.spec tests.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12361-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #570
----
commit 494f5e9749fcdb82b4c7052c413e2bc4af494d7a
Author: filmaj <[email protected]>
Date: 2017-06-16T23:07:13Z
Filling out more addHelper specs.
commit 34e4a00aec170741fea2a744eb089fa36100867b
Author: filmaj <[email protected]>
Date: 2017-06-16T23:31:40Z
finished laying out pending specs for main addhelper function.
commit fa4d7c59c2069540080450362f9cd6b7c7e6e484
Author: filmaj <[email protected]>
Date: 2017-06-17T00:00:58Z
further pending tests and some todos.
commit ba6702c88f09497b6ee5eb0e2564fdb5a3478153
Author: filmaj <[email protected]>
Date: 2017-06-19T13:56:00Z
already have tests for checking targets passed in to platform-add lined up
elsewhere.
commit ab8cd73e1810eb241caa6ac595f25c7bb42101c2
Author: filmaj <[email protected]>
Date: 2017-06-19T14:33:05Z
filled out a few tests, more comments to describe testing approach.
commit 3dbc8073ab020b98059d0920793ac979dc1d8b60
Author: Audrey So <[email protected]>
Date: 2017-06-26T22:37:00Z
CB-12361 : updated addHelper tests
----
> Speed up cordova-lib tests
> --------------------------
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
