[
https://issues.apache.org/jira/browse/CB-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082662#comment-16082662
]
ASF GitHub Bot commented on CB-13006:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/394
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=h1)
Report
> Merging
[#394](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/90053eb9dfc03c6cdab31aab665324556c3358be?src=pr&el=desc)
will **increase** coverage by `1%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #394 +/- ##
========================================
+ Coverage 41.54% 42.55% +1%
========================================
Files 16 17 +1
Lines 1497 1678 +181
Branches 279 304 +25
========================================
+ Hits 622 714 +92
- Misses 875 964 +89
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
| `50.82% <72.72%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=footer).
Last update
[90053eb...5917d4e](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Move e2e create tests to unit tests
> -----------------------------------
>
> Key: CB-13006
> URL: https://issues.apache.org/jira/browse/CB-13006
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Filip Maj
> Assignee: Filip Maj
>
> Instead of having these tests shell out to create (and also compile!) the
> cordova-android project, we should write up unit tests to ensure that the
> functionality the tests are trying to cover (support for ascii/unicode/spaces
> in project names).
> This would really speed up our testing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
