[
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082930#comment-16082930
]
ASF GitHub Bot commented on CB-11244:
-------------------------------------
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Just based on the last travis/appveyor run in the commits in this PR, the
unit tests, end to end tests and the native unit tests are not running.
I don't see master HEAD in the commit list for this branch, either:
```
* a7304b9a - (HEAD -> StudioProjectCompat, infil00p/StudioProjectCompat)
Finishing the linting (2 weeks ago) <Joe Bowser>
* e456175a - Merge branch 'master' into StudioProjectCompat (2 weeks ago)
<Joe Bowser>
|\
| * 55d7cf38 - CB-12895 : updated .eslintrc file in spec dir and set
jasmine true and removed root is true (3 weeks ago) <Audrey So>
| * ac4ac935 - CB-12895 : added .eslintrc files to set up jasmine
environment (3 weeks ago) <Audrey So>
| * d83d49d8 - CB-12895 : fixed eslint errors (3 weeks ago) <Audrey So>
| * e36158a0 - CB-12895 : added eslint and removed jshint (3 weeks ago)
<Audrey So>
| * 5cc14b80 - CB-12605 In Windows get Android studio path from the
registry (3 weeks ago) <Jesse MacFadyen>
* | b20028c4 - (infil00p/StudioProjectCleanup, StudioProjectCleanup) The
prepare step was broken, which breaks the CLI workflow. This was caused by
hardcoding the Java directory, which is a very bad idea. (3 weeks ago) <Joe
Bowser>
* | 1cda7a9d - CB-11244: Found bug in Api.js where xml/strings.xml is used
instead of values/strings.xml (3 weeks ago) <Joe Bowser>
* | 49b76f5c - Fixing mangled commits that crept into this branch (4 weeks
ago) <Joe Bowser>
* | c0474e81 - Bump for travis test (4 weeks ago) <Joe Bowser>
* | 40c97094 - OK, Going back to the old build.gradle for legacy projects
(4 weeks ago) <Joe Bowser>
* | b67e9905 - This is probably a bad idea, but we need to split the gradle
files into legacy and new style (4 weeks ago) <Joe Bowser>
* | c74192d5 - Adding conditional code into Gradle, this is a bit dirty
since we can't explicitly test it but we'll just have to rely on jasmine (4
weeks ago) <Joe Bowser>
* | 33feb00e - Adding the if statement to see if we can support both
structures with minimal editing, TODO: actually write tests for this somehow (4
weeks ago) <Joe Bowser>
* | 8f16df4c - Adding logic to upgrade both Classic and Android Studio
style project structures (4 weeks ago) <Joe Bowser>
* | fb6cb51e - Fixing lint errors (4 weeks ago) <Joe Bowser>
* | 28ebbb8f - CB-11244: Setup Api.js to support multiple builders based on
project structure (4 weeks ago) <Joe Bowser>
* | bd4ddcde - Updated AndroidStudio to only look for the app directory to
determine studio status (4 weeks ago) <Joe Bowser>
* | e621edfb - Fixing the Android Studio detection and making it
automatically pick the right builder, good for upgrading Cordova (4 weeks ago)
<Joe Bowser>
* | 304a8991 - Fixed the specification of the builders in the run command
by getting build to check what was being passed from run (4 weeks ago) <Joe
Bowser>
* | 8391af2e - JsHint Fixes, deleting unused methods (4 weeks ago) <Joe
Bowser>
* | 69ab6a0e - Changing the project to add the app directory as a
dependency (4 weeks ago) <Joe Bowser>
* | a216f0db - CB-11244: Changing directory creation, will most likely hide
this behind a flag for the next release of Cordova-Android, and then make it
default in the next major pending feedback (4 weeks ago) <Joe Bowser>
* | 69260fb9 - Fix the overwriting of Fil's fix, blargh (4 weeks ago) <Joe
Bowser>
* | db87e0ae - Made changes so cordova/build builds with the new project.
Need to work on plugin installation. (4 weeks ago) <Joe Bowser>
* | 8ead919f - Managed to get the project to mostly compile, still need to
re-work the build command to add the app project (4 weeks ago) <Joe Bowser>
* | b73c04f3 - Updating gradle version in the build file (4 weeks ago) <Joe
Bowser>
* | f790aeb8 - Setting up the create command so we actually have all the
directories in the right place, and define default variables in the top level
build.gradle (4 weeks ago) <Joe Bowser>
* | 7b17abc5 - Fixing linting issues (4 weeks ago) <Joe Bowser>
* | ffadf5dd - Changing this so we pass lint (4 weeks ago) <Joe Bowser>
* | 23d8d999 - Moving Android Manifest finding to the Gradle and Studio
builders. (4 weeks ago) <Joe Bowser>
* | d88df59c - Adding the Studio Builder to build a project based on
Android Studio, and deleting Ant, since Google does not support Ant Builds
anymore. Sorry guys! (4 weeks ago) <Joe Bowser>
|/
* 3a6e898b - CB-12762 : pointed package.json repo items to github mirrors
instead of apache repos site (5 weeks ago) <Audrey So>
```
> Update Android Project Structure to be more compatible with Android Studio
> --------------------------------------------------------------------------
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project
> structure created by default, even for new projects, which makes no sense
> since we no longer support Eclipse as the default project editor and have
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for
> projects and dependencies to work more like how modern Android projects work
> and to remove as much custom Gradle code as possible. This would also allow
> us in the future to move towards having Android Plugin code work as Android
> Libraries with Resources instead of just copying things across, which gives
> us the ability to add JUnit tests and bundled resources. This would
> dramatically increase the quality of plugins such as InAppBrowser, and third
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would
> be tricky to do. However, the benefits at this point would greatly outweigh
> the costs of maintaining the old project structure. The old cordova-common
> code in Cordova-Android 5.0.x would allow for plugins in the short term to
> work with both projects until we get the new project structure ready.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
