[ 
https://issues.apache.org/jira/browse/CB-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087308#comment-16087308
 ] 

ASF GitHub Bot commented on CB-13022:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-windows/pull/238

    CB-13022 Correct a VS installation warning during check_reqs

    ### Platforms affected
    this one!
    
    ### What does this PR do?
    Corrects a warning message that asks a user to install VS.
    
    ### What testing has been done on this change?
    none
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-windows CB-13022

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit 6f7c29f5d97aea93dc32a263a0427ddaa69e20e4
Author: Alexander Sorokin <alexander.soro...@akvelon.com>
Date:   2017-07-14T13:18:22Z

    CB-13022 Correct a VS installation warning during check_reqs

----


> cordova-windows' check_reqs asks for VS 2013/2015, but any higher version 
> would do
> ----------------------------------------------------------------------------------
>
>                 Key: CB-13022
>                 URL: https://issues.apache.org/jira/browse/CB-13022
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>
> When a user doesn't have VS installed and runs {{check_reqs}}, the following 
> warning is displayed:
> {noformat}
> Requirements check results for windows:
> Windows OS: installed Windows 10
> MSBuild Tools: not installed
> MSBuild tools v.14.0 not found. Please install Visual Studio 2015 Community 
> from https://www.visualstudio.com/downloads/download-visual-studio-vs
> Visual Studio: not installed
> Required version of Visual Studio not found. Please install Visual Studio 
> 2015 Community from 
> https://www.visualstudio.com/downloads/download-visual-studio-vs
> Windows SDK: installed 10.0
> Windows Phone SDK: installed 10.0
> Error: Some of requirements check failed
> {noformat}
> The phrase "Please install Visual Studio 2015 Community" is somewhat 
> misguiding, because any higher version of VS also will do.
> I propose to insert "or higher" here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to