[
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092924#comment-16092924
]
ASF GitHub Bot commented on CB-12969:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
CB-12969 android: Added support for data URIs
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Adds support for data Uri (e.g. `'data:text/html,
<html><body><h1>Hello</h1></body></html>'`)
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-plugin-inappbrowser
CB-12969
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #227
----
commit d2a30038852165fcc4233dd13f03d3cc1eedc77c
Author: Nikita Matrosov <[email protected]>
Date: 2017-07-19T10:51:34Z
CB-12969 android: Added support for data URIs
----
> InAppBrowser - Cannot open data URLs in system browser
> ------------------------------------------------------
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
> Reporter: Sachitra Malwatte
> Assignee: Nikita Matrosov
> Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, <html><body><h1>Hello</h1></body></html>',
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g.
> window.open('https://github.com/apache/cordova-plugin-inappbrowser',
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
