[
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099455#comment-16099455
]
ASF GitHub Bot commented on CB-12730:
-------------------------------------
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/399
CB-12730: Compat - INTEGRATE
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR integrates cordova-plugin-compat directly into cordova-android.
Going forward you will not need to add this plugin to your project.
### What testing has been done on this change?
Created a new cordova-android project using this branch. Added a custom
version of barcode scanner that does not depend on cordova-plugin-compat. When
the app runs the permission dialog is displayed properly when I request to scan
a barcode and it allows access to the camera when I allow the permission.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/macdonst/cordova-android CB-12730
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit 0e0062c4453adeed7233e2550de933555c0e3315
Author: Simon MacDonald <simon.macdon...@gmail.com>
Date: 2017-07-25T03:40:01Z
CB-12730: Compat - INTEGRATE
----
> Compat - INTEGRATE
> ------------------
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-compat
> Reporter: Shazron Abdullah
>
> See parent issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
